Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show brand field for cinema preset #119

Closed
bhousel opened this issue Jan 28, 2021 · 2 comments
Closed

Show brand field for cinema preset #119

bhousel opened this issue Jan 28, 2021 · 2 comments

Comments

@bhousel
Copy link
Member

bhousel commented Jan 28, 2021

This relates to openstreetmap/iD#5515

By convention iD will show:

  • both the "name" and "brand" fields for presets where we may want to lock the "brand" and let the user change the "name", and
  • "name" only for presets where we might want to lock the name

Cinemas are in the first category and should show both "name" and "brand" so users can customize the name field, e.g. "AMC Mountainside 10"

@tyrasd
Copy link
Member

tyrasd commented Jan 5, 2022

As far as I can see, the cinema preset already has the brand field (since openstreetmap/iD@5ab7134). Am I missing something here?

@tyrasd tyrasd added the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Jan 5, 2022
@bhousel
Copy link
Member Author

bhousel commented Jan 5, 2022

Oh yeah, I think the behavior I described only happens if the field is in fields but not in moreFields.

But I don't need this anymore, I added a workaround in the NSI project to generate the branded presets with the name and brand/operator fields up at the top of the fields array.

@bhousel bhousel closed this as completed Jan 5, 2022
@tyrasd tyrasd removed waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques add-field labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants