-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show ref in the name of route relations #8707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just told
not ready to merge |
hello @papac25, could you please explain why this is "not ready to merge"? |
Most of bus routes have already have "ref" in the name tag. It is a needless duplication, I think. |
There are some mappers who insist that the @HermanLeeZh Is there a recommended format for the name when it contains the ref? |
@k-yle Maybe you can look up this wiki page. Here provide a |
Yes, I agree with @HermanLeeZh 's opinion, if we follow PTv2 name style, the display will make The I suggest this new display schema should detect whether BTW, the tagging schema truly have a lot of version, such as PTv1, PTv2, Oxomoa schema, Zverik schema The name style of Zverik schema are the same as PTv2 |
Most of relations follow the PTv2 now.page |
Great, thanks @HermanLeeZh and @LaoshuBaby ! I think we can close this PR then. I'll send this link to anyone who complains about sticking the |
Did you all miss the footnote on that wiki page? 😄 The strict name format was indeed part of the original proposal, but it is now widely discredited as a prominent example of “tagging for the editor”, as seen in the links I listed in this discussion. Reducing iD’s dependency on the legacy name format was also the original motivation for #8276. @k-yle, if you’re still interested in pushing this change to completion, maybe there’s a way to accommodate the legacy format in the interim, while other editors sort out their relation support. For example, we could make it so that the ref only appears for disambiguation purposes if the name doesn’t already contain it. That would avoid the potential confusion of a duplicated number and avoid unduly influencing mapper behavior. |
@1ec5 Emm, I have noticed the footnote. I agree. I find the state is that most routes have |
The main idea of that footnote (and the email) is we are wrong use the Like @1ec5 said in #8276 's Rationale part:
For @HermanLeeZh :
If one day most data have comprehensive metadata tag and our major data consumer started to use structured data first, I agree with the assembled name like This situation is because the assembled-name schema haven't allow a ref, the best way is to deprecated current naming process , and let all editor changed to combine different part of metadata in a specific schema (whatever it is). It need we unite all community to review all current relation, and all editor such as JOSM, iD, Potlatch and so on announced they change to this way. It is so hard so I think this is impossible So, I retreat to the second best, I personally encourage and strongly support naming Thanks you all for read this. :) |
It is not impossible to make editors less reliant on the descriptive name format. It’s circular logic to claim it’s impossible to make this change as a reason to prevent iD from making this change. Coordination is not a bad idea, but @k-yle and I have been very careful not to rush any changes in iD that would lead to relations going unlabeled in JOSM overnight. This PR was only about displaying something more informative when a route happens to be named like it is in the real world. The descriptive names are purely an editor concern. It’s quite unlikely that any data consumer goes out of their way to parse route numbers, origins, and destinations out of As important as PTv2 schema may be, it’s even more important to avoid tagging for the |
Closes #8559, cc @1ec5
Editing bus routes with similar names is very confusing. Especially when the
ref
is what you use conversationally, not thename
.This PR changes
utilDisplayName
to use both thename
and theref
tag, but only for routes.