Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with trying to add a name for post boxes that are tagged with brand #6890

Closed
Elefant-aus-Wuppertal opened this issue Sep 27, 2019 · 2 comments · Fixed by #8305
Closed
Labels
waitfor-upstream Waiting for something in an upstream project

Comments

@Elefant-aus-Wuppertal
Copy link
Contributor

Hi,
please have a look at https://www.openstreetmap.org/node/2293452747

this post box is tagged with brand=Deutsche Post because it's not just the operator, but a kind of brand acting in the post business in germany. The issue is now that iD wants to add not only the correct brand:wikipedia tag, but also "name=Deutsche Post" which would be clearly wrong for a post box, wouldn't it?

@quincylvania
Copy link
Collaborator

@Lukas458 This is an effect of name suggestion index entries needing a name tag. (iD gets its brand suggestions from there). I'm not intimately familiar with that project but you could try researching or asking about the issue over there.

If the NSI adds a mechanism to make name tags optional or malleable then iD could support it. But again, I'm no expert on this.

@bhousel
Copy link
Member

bhousel commented Sep 30, 2019

I agree that for some entries from NSI we should prioritize operator instead of brand, and for these we might make name optional or exclude it entirely.. post_box is a good example of this kind of feature. (FWIW iD has been using name this way for at least 5 years, so it's not really a new issue, but there is a lot more visibility into NSI now that the validator uses it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waitfor-upstream Waiting for something in an upstream project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants