[FEATURE]Support of new k-NN query parameter, expand_nested_docs #1008 #1013
Conversation
bzhangam
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
| @@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| ### Features | |||
| ### Enhancements | |||
| - Set neural-search plugin 3.0.0 baseline JDK version to JDK-2 ([#838](https://github.com/opensearch-project/neural-search/pull/838)) | |||
| - Support new knn query parameter expand_nested_docs ([#1008](https://github.com/opensearch-project/neural-search/issues/1008)) | |||
There was a problem hiding this comment.
You may put PR link instead of issues link here. It should be: #1013
There was a problem hiding this comment.
This is put in Unreleased 3.0 part, just wondering should this feature be part of Unreleased 3.0 or Unreleased 2.x?
There was a problem hiding this comment.
Seems like this is new feature, should be it under Features or Enhancements?
There was a problem hiding this comment.
You may put PR link instead of issues link here. It should be: #1013
That is correct. Should be this PR link.
This is put in Unreleased 3.0 part, just wondering should this feature be part of Unreleased 3.0 or Unreleased 2.x?
Should be under Unreleased 2.x
Seems like this is new feature, should be it under Features or Enhancements?
Kind of subjective matter. Enhancements might looks fine by me.
| @@ -98,6 +99,7 @@ public static void initialize(MLCommonsClientAccessor mlClient) { | |||
| private Integer k = null; | |||
| private Float maxDistance = null; | |||
| private Float minScore = null; | |||
| private Boolean expandNestedDocs; | |||
There was a problem hiding this comment.
nit: new line below this line.
Description
Support new knn query parameter
expand_nested_docs.Related Issues
Resolves #1008
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.