Correct parsing for f-string string literal concatenation #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #91 Add support for f-string literal concatenation in the Python parser. * **Py.java** - Add a new nested `StringLiteralConcatenation` type to handle string literal concatenation. - Implement `getType()` to return `JavaType.Primitive.String`. - Implement `setType()` to return `this`. * **_parser_visitor.py** - Update the `visit_Constant` method to handle string literal concatenation combined with f-strings. - Add logic to produce `Py.StringLiteralConcatenation` nodes for string literal concatenation. - Update the `__map_fstring` method to handle the difficult piece of logic for f-string concatenation. * **fstring_test.py** - Add tests to verify correct parsing of string literal concatenation combined with f-strings. - Add tests to verify correct parsing of f-string literal concatenation with comments. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/openrewrite/rewrite-python/issues/91?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
Add support for f-string literal concatenation in the Python parser.
Py.java
StringLiteralConcatenationtype to handle string literal concatenation.getType()to returnJavaType.Primitive.String.setType()to returnthis._parser_visitor.py
visit_Constantmethod to handle string literal concatenation combined with f-strings.Py.StringLiteralConcatenationnodes for string literal concatenation.__map_fstringmethod to handle the difficult piece of logic for f-string concatenation.fstring_test.py
For more details, open the Copilot Workspace session.