Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: tests(odh-nbc): update to the latest route crd #442

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 6, 2024

Found during work on https://issues.redhat.com/browse/RHOAIENG-14784 but is not really related.

Description

There's an issue I encountered that when I was pre-populating some routes in a test, when I was setting the status, I was getting errors because status was not declared as subresource in the CRD we were using before.

I am therefore updating the CRD we use in tests using one that comes directly from OpenShift.

How Has This Been Tested?

make test

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

There's an issue I encountered that when I was prepopulating some routes in a test,
when I was setting the `status`, I was getting errors because status was not declared as subresource in the CRD we were using before.

I am therefore updating the CRD we use in tests using one that comes directly from OpenShift.
… CRD since our test values we use are not valid
@openshift-ci openshift-ci bot requested review from caponetto and dibryant November 6, 2024 17:24
Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek self-assigned this Nov 6, 2024
@jiridanek
Copy link
Member Author

/test odh-notebook-controller-e2e

@jstourac
Copy link
Member

Regarding the source of truth you used - https://github.com/openshift/microshift/blob/release-4.12/assets/crd/route.crd.yaml - are we sure this is the best place (and version) we should gather it from?

@jiridanek
Copy link
Member Author

are we sure this is the best place (and version) we should gather it from?

I like that one; OpenShift is not making breaking changes in its core crds, so this crd is correct, and it is not as complicated as the later versions; 4.12 is nice and relatively simple. Only problem is the regex validataion patterns that I had to comment out because they break existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants