Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git tags for releases #128

Open
pjonsson opened this issue Jan 17, 2024 · 12 comments
Open

Make git tags for releases #128

pjonsson opened this issue Jan 17, 2024 · 12 comments

Comments

@pjonsson
Copy link
Collaborator

In commit d4214dc, @alexgleith bumped index/version.txtand a 0.3.1 image appeared on https://hub.docker.com/r/opendatacube/datacube-index/tags, but according to the Github UI there are no releases of this repository, and the only tag in git is build-number-5.

The explorer repository has both releases and git tags. Could releases of this repository get a git tag so it is clear what images on Dockerhub are built from?

@alexgleith
Copy link
Contributor

This is a good point, @pjonsson.

The versioning with a text file comes from the past, where there were multiple Docker images in this repo.

Now there's only one, it could work via releases. The name of the repo could be changed too, perhaps.

I'd be happy to give you permissions on the repo to do this work if you are willing?

@pjonsson
Copy link
Collaborator Author

Sure, if nobody else beats me to it, I should be able to make time for this in February.

I don't have an overview over all your repositories, but if the other Dockerfile in this repository moved into the "upstream" repository, should the remaining Dockerfile also be moved to some other (already existing) repository?

@alexgleith
Copy link
Contributor

Ok, invited you. Feel free to send a PR to me if you want input.

@pjonsson
Copy link
Collaborator Author

Our immediate problem is the lack of tags, so I made a draft of a 0.3.1 release where the "release notes" mentioned the updates since 0.3.0 and contained a link to the commits included in the version. I believe publishing the release will also create the git tag.

This is not crazy urgent but I'm traveling next week, so when you have time during regular work hours, please take a look at the release draft and tweak/publish as you deem suitable.

Will get back to the rest of the stuff you mentioned in February, thanks for the help so far!

@alexgleith
Copy link
Contributor

Looks good! I changed it slightly to 0.3.1 without the v at the start.

Also added the "tag", see the image below.

image

When it comes to Updating the Action, we can add pushing to the GitHub Container Repository, or just to Docker Hub. I'd be inclined to push to both... or to only GHCR even!

Here's an example action that pushes to GHCR https://github.com/digitalearthpacific/dep-geomad/blob/main/.github/workflows/build-test-docker.yml

@pjonsson
Copy link
Collaborator Author

@alexgleith sorry about my silence, I thought I would have time to work on this in February but all my spare cycles have been consumed lately and the next weeks are looking bleak too. I hope to resurface for this ticket in roughly a month.

@pjonsson
Copy link
Collaborator Author

pjonsson commented Apr 6, 2024

(To be edited)
Referencing technical notes from various places:

@pjonsson
Copy link
Collaborator Author

@alexgleith I'm interested in trying the 1.9 pre-releases of opendatacube, but that doesn't seem like it should be merged to the main branch of this repository, it seems better suited for the develop-1.9 branch in the datacube-core repository.

My understanding is that there used to be other docker files in this repository but they migrated into their parent repositories, do you see a reason to keep this repository long-term, or should we try to get the remaining Dockerfile+belongings from this repository into the repository where the main package is developed?

@alexgleith
Copy link
Contributor

Hi @pjonsson

I really think this indexing docker image should go in https://github.com/opendatacube/odc-tools.

A super simple Docker image in there will work well.

@pjonsson
Copy link
Collaborator Author

I love having fewer repositories, but I'm not sure I follow your train of thought. Will moving this content to that repository make it possible to get both 1.8-images and 1.9-pre-release images (or 1.9 and 2.0-images in the future)?

@alexgleith
Copy link
Contributor

Yeah, well, datacube 1.9 prerelease can already be included.

It'll need a new requirements and maybe a pre-release tag, but that's easy enough.

@pjonsson
Copy link
Collaborator Author

Ok, I'll start looking into that, hopefully before the end of this week.

And as a remark, that repository also seems to be missing release tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants