Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve tool]: implement reset-peer commnad #2018

Closed
ilixiaocui opened this issue Nov 3, 2022 · 5 comments
Closed

[curve tool]: implement reset-peer commnad #2018

ilixiaocui opened this issue Nov 3, 2022 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@ilixiaocui
Copy link
Contributor

ilixiaocui commented Nov 3, 2022

Describe the feature you'd like:

we'd like to support reset-peer command in curve tool

reset-peer is one of the commands to make configuration changes to a raft replication group.

  • The implementation of the old tool is here:
    int CurveCli::ResetPeer() {
  • The old command input and out put:
    reset-peer : reset the configuration of copyset, only reset to one peer is supported
    
    curve_ops_tool reset-peer --example
    Example
    curve_ops_tool reset-peer -logicalPoolId=1 -copysetId=10001 -peer=127.0.0.1:8080:0 -new_conf=127.0.0.1:8080:0 -max_retry=3 -timeout_ms=100
    
    output:
    reset peer ok
    

Teachability, Documentation, Adoption, Migration Strategy:

Refer to tool develop guide to get start, and paste the result of the command in pr.

@ilixiaocui ilixiaocui added the good first issue Good for newcomers label Nov 3, 2022
@ilixiaocui ilixiaocui changed the title [curve tool]: implement remove-peer commnad [curve tool]: implement reset-peer commnad Nov 3, 2022
@zhanghuidinah
Copy link
Member

/assign @whalecold

@ilixiaocui
Copy link
Contributor Author

Please note that the code submission deadline for this developer activity is December 3rd :)
@whalecold

@wuhongsong
Copy link
Contributor

@whalecold If you are free, you are welcome to continue the work

@whalecold
Copy link
Member

@whalecold If you are free, you are welcome to continue the work

my pleasure

@ilixiaocui
Copy link
Contributor Author

cc @whalecold Is this issue still being followed up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants