Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(azure): update example and readme to use Entra ID #857

Merged
merged 3 commits into from
May 30, 2024
Merged

docs(azure): update example and readme to use Entra ID #857

merged 3 commits into from
May 30, 2024

Conversation

deyaaeldeen
Copy link
Contributor

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Update Azure code examples to use Entra ID instead of API keys.

Additional context & links

@deyaaeldeen deyaaeldeen requested a review from a team as a code owner May 16, 2024 18:34
RobertCraigie
RobertCraigie reviewed May 16, 2024
View reviewed changes
examples/azure.ts Outdated Show resolved Hide resolved
examples/azure.ts Show resolved Hide resolved
@deyaaeldeen deyaaeldeen requested a review from RobertCraigie May 17, 2024 17:36
RobertCraigie
RobertCraigie reviewed May 20, 2024
View reviewed changes
README.md
> won't always be correct.

```ts
const openai = new AzureOpenAI();
import { AzureOpenAI } from 'openai';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realising now that we don't mention the environment variables the azure client supports, e.g. AZURE_OPENAI_ENDPOINT & AZURE_OPENAI_API_KEY, we should mention these in the README as well. (doesn't block this PR)

RobertCraigie
RobertCraigie approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I think CI should run if you target the next branch fyi

@deyaaeldeen deyaaeldeen changed the base branch from master to next May 22, 2024 04:22
@deyaaeldeen
Copy link
Contributor Author

I think CI should run if you target the next branch fyi

Done.

@deyaaeldeen deyaaeldeen requested a review from RobertCraigie May 30, 2024 17:15
@stainless-bot stainless-bot changed the title [Azure] Update example and readme to use Entra ID docs(azure): Update example and readme to use Entra ID May 30, 2024
@stainless-bot stainless-bot changed the title docs(azure): Update example and readme to use Entra ID docs(azure): update example and readme to use Entra ID May 30, 2024
@stainless-bot stainless-bot merged commit 722eff1 into openai:next May 30, 2024
2 checks passed
@stainless-app stainless-app bot mentioned this pull request May 30, 2024
Merged
@deyaaeldeen deyaaeldeen deleted the azure-sample-entra branch May 30, 2024 23:37
stainless-app bot pushed a commit that referenced this pull request May 31, 2024
@deyaaeldeen @stainless-app
docs(azure): update example and readme to use Entra ID (#857)
0152859
This was referenced Jun 23, 2024
Merged
Merged
This was referenced Jun 28, 2024
Open
Open
@SherfeyInv SherfeyInv mentioned this pull request Jun 30, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 2, 2024
Merged
@wqyeo wqyeo mentioned this pull request Jul 10, 2024
Open
@jan-service-account jan-service-account mentioned this pull request Jul 12, 2024
Open
deyaaeldeen added a commit to deyaaeldeen/openai-node that referenced this pull request Aug 10, 2024
@deyaaeldeen
docs(azure): update example and readme to use Entra ID (openai#857)
7a1447e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertCraigie RobertCraigie Awaiting requested review from RobertCraigie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deyaaeldeen @RobertCraigie @stainless-bot