fix(headers): always send lowercase headers and strip undefined (BREAKING in rare cases) #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…KING in rare cases) BREAKING: If you previously sent `My-Header: foo` and `my-header: bar`, both would get sent. Now, only one will. If you previously sent `My-Header: undefined`, it would send as such. Now, the header will not be sent.
Merged
stainless-bot
added a commit
that referenced
this pull request
Jan 9, 2024
…KING in rare cases) (#608) BREAKING: If you previously sent `My-Header: foo` and `my-header: bar`, both would get sent. Now, only one will. If you previously sent `My-Header: undefined`, it would send as such. Now, the header will not be sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: If you previously sent
My-Header: fooandmy-header: bar,both would get sent. Now, only one will.
If you previously sent
My-Header: undefined, it would send as such.Now, the header will not be sent.