Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User city and region detection #317

Open
GoulvenF opened this issue Apr 2, 2024 · 2 comments
Open

User city and region detection #317

GoulvenF opened this issue Apr 2, 2024 · 2 comments
Labels
feature New feature or request good first issue Can be achieved without a specific knowledge of the open4goods / nudger project help wanted Would be so happy to have someone contributing on this topic ! java Pull requests that update Java code

Comments

@GoulvenF
Copy link
Contributor

GoulvenF commented Apr 2, 2024

Version française (google translate)

Problem

  • We will need to operate user localisation, to allow funding of local causes
  • but we will need to make in in a GDPR respectuous way and in a "no cookie" mode

Solution

  • Implement a cool spring filter, that allows user localisation based on its ip.

Requisites

  • Will have to cross check with INSEE data, to retrieve country code, region, postal code and so, for france in a first time.
  • must be fast, and provide a short window IP caching mechanism.
  • should be a spring approach, or something that can easily be applied in spring context

Tips / work tracks

  • Can have a look at the commented commons/src/main/java/org/open4goods/services/GeolocService.java, a dirty maxmind implementation of this kind of stuf
  • maybe something exists, or could be a new, separate spring boot starter project ?
@GoulvenF GoulvenF added feature New feature or request good first issue Can be achieved without a specific knowledge of the open4goods / nudger project help wanted Would be so happy to have someone contributing on this topic ! java Pull requests that update Java code labels Apr 2, 2024
@Ashwinn11
Copy link
Contributor

I want to work on this. May I know what is the problem with maxmind implementation?

@GoulvenF
Copy link
Contributor Author

GoulvenF commented May 20, 2024

Hi Ashwinn,

Thanks again for tour interest in the project ! Nothing bad with maxmind, but a cool reusable spring filter (interceptor ?) that embeds maxmind geolocation, with IP resolution caching and plugable location information extension (an example for france here : https://www.data.gouv.fr/fr/datasets/communes-de-france-base-des-codes-postaux/) would be very cool !

Not an so easy part, and the "localized" operations (eg : regions enrichment) could/should probably be delayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Can be achieved without a specific knowledge of the open4goods / nudger project help wanted Would be so happy to have someone contributing on this topic ! java Pull requests that update Java code
Projects
None yet
Development

No branches or pull requests

2 participants