Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTLP Exporter - initialize Reqwest::Blocking client must be done in non async context #2400

Open
cijothomas opened this issue Dec 9, 2024 · 3 comments · May be fixed by #2431
Open

OTLP Exporter - initialize Reqwest::Blocking client must be done in non async context #2400

cijothomas opened this issue Dec 9, 2024 · 3 comments · May be fixed by #2431
Assignees
@pitoniak32
Labels
M-exporter-otlp
Milestone
0.28.0

Comments

@cijothomas
Copy link
Member

cijothomas commented Dec 9, 2024 •
edited
Loading

Related to #1757
Currently, initializing OTLP Exporter causes the creation of Reqwest::blocking client creation. If the user's main thread is a tokio::main or other asyn runtime context, this panics.

Reqwest::blocking client must be created separately to avoid this panic. Options include spinning up a throwaway thread, just for the sake of initializing the blocking client, or delaying the creation of client until 1st export.

Required for #2386
@cijothomas cijothomas added this to the 0.28.0 milestone Dec 9, 2024
@cijothomas
Copy link
Member Author

@pitoniak32 Something you want to give a try?

@pitoniak32
Copy link
Contributor

I can take a look at it. It might take me a little bit since I will probably need to do some research. I'll let you know if I run into issues though

@cijothomas cijothomas mentioned this issue Dec 10, 2024
Open
@cijothomas
Copy link
Member Author

#2189 can be closed once this is addressed.

@pitoniak32 pitoniak32 linked a pull request Dec 15, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitoniak32 pitoniak32

Labels
M-exporter-otlp
Projects
None yet
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

otlp: spawn thread to create blocking reqwest client pitoniak32/opentelemetry-rust
2 participants
@cijothomas @pitoniak32