Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: separate metric_exporter out of metric_reader #1779

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

refactor: separate metric_exporter out of metric_reader #1779

wants to merge 6 commits into from

Conversation

xuan-cao-swi
Copy link
Contributor

Closes #1723

Description

  • Made the interface-like metric_exporter class. Every exporter should inherit from this metric_exporter.
  • Change the oltp metrics_exporter to inherit from metric_exporter.
  • With the refactor/separation of metric_reader, now the metric_reader should be able to have multiple exporters and modify the default aggregation/temporarily of instrument.
  • Updated the test case for the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany will be requested when the pull request is marked ready for review fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear will be requested when the pull request is marked ready for review mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin will be requested when the pull request is marked ready for review robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma will be requested when the pull request is marked ready for review dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin will be requested when the pull request is marked ready for review ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin will be requested when the pull request is marked ready for review arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth will be requested when the pull request is marked ready for review ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam will be requested when the pull request is marked ready for review plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd will be requested when the pull request is marked ready for review robbkidd is a code owner

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle kaylareopelle will be requested when the pull request is marked ready for review kaylareopelle is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
metrics
Projects
Ruby - Metrics
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics reader supports configuring aggregation and temporality
2 participants
@xuan-cao-swi @kaylareopelle