Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Implement Advisory Parameters #1686

Open
kaylareopelle opened this issue Aug 16, 2024 · 3 comments
Open

Metrics: Implement Advisory Parameters #1686

kaylareopelle opened this issue Aug 16, 2024 · 3 comments
Assignees

Comments

@kaylareopelle
Copy link
Contributor

To help update bucket boundaries for instruments in instrumentation, implement advisory parameters (AKA advice)

API: https://opentelemetry.io/docs/specs/otel/metrics/api/#instrument-advisory-parameters
SDK: https://opentelemetry.io/docs/specs/otel/metrics/sdk/#instrument-advisory-parameters
JS implementation example: open-telemetry/opentelemetry-js#3876
JS instrumentation example: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/770130a7a41125dbf8a8c18b3384e5fcc370deef/plugins/node/instrumentation-undici/src/undici.ts#L127-L141

@kaylareopelle
Copy link
Contributor Author

Right now, just working on the explicit bucket boundaries advisory parameter. Attributes is marked as experimental. Checking in on open-telemetry/opentelemetry-specification#3785 to see if it's stable enough to implement.

Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale label Nov 1, 2024
@kaylareopelle kaylareopelle added keep and removed stale labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Status: Placeholder
Development

No branches or pull requests

1 participant