Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL_RESOURCE_ATTRIBUTES parsing has whitespace in keys #1540

Open
inssein opened this issue Nov 3, 2023 · 3 comments · May be fixed by #1541
Open

OTEL_RESOURCE_ATTRIBUTES parsing has whitespace in keys #1540

inssein opened this issue Nov 3, 2023 · 3 comments · May be fixed by #1541
Labels
bug Something isn't working keep

Comments

@inssein
Copy link

inssein commented Nov 3, 2023 •
edited
Loading

We run all of our services in Kubernetes, and define our open telemetry resource attributes like so:

            - name: OTEL_RESOURCE_ATTRIBUTES
              value: >
                service.name=redacted,
                service.version=redacted,
                k8s.node.name=$(KUBE_NODE_NAME),
                k8s.pod.name=$(KUBE_POD_NAME),
                k8s.pod.uid=$(KUBE_POD_ID),
                k8s.namespace.name=$(KUBE_NAMESPACE)

All of our other services (java, python) seem to split on "=" and then clean up whitespace in the key, but unfortunately the ruby library sends over service.version=redacted (note the whitespace in front of the key).

Looks like the problem is here: https://github.com/open-telemetry/opentelemetry-ruby/blob/main/sdk/lib/opentelemetry/sdk/resources/resource.rb#L47-L50
@inssein inssein added the bug Something isn't working label Nov 3, 2023
@inssein inssein linked a pull request Nov 3, 2023 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale label Mar 2, 2024
@kaylareopelle
Copy link
Contributor

This is being worked on in #1541

@github-actions github-actions bot removed the stale label Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale label Apr 5, 2024
@kaylareopelle kaylareopelle added keep and removed stale labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working keep
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up whitespace in OTEL_RESOURCE_ATTRIBUTES inssein/opentelemetry-ruby
2 participants
@inssein @kaylareopelle