Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testbed] Add resource limits to benchmark results file #36720

Open
bacherfl opened this issue Dec 9, 2024 · 1 comment · May be fixed by #36753
Open

[testbed] Add resource limits to benchmark results file #36720

bacherfl opened this issue Dec 9, 2024 · 1 comment · May be fixed by #36753
Labels
enhancement New feature or request needs triage New item requiring triage testbed

Comments

@bacherfl
Copy link
Contributor

bacherfl commented Dec 9, 2024

Component(s)

testbed

Is your feature request related to a problem? Please describe.

Currently, the benchmark results file generated by the testbed includes the achieved max and average values for the CPU and memory usage - see here. It would however also be useful to include the CPU/memory limits specified for the respective test as well, to be able to visualise how close the actual consumption is to the limits.
Therefore I'd like to propose adding these values to the generated overview

Describe the solution you'd like

Modify the PerformanceResults.Add() method to also include the limits for the CPU and memory consumption.

Describe alternatives you've considered

No response

Additional context

I'm already on a PR for this, will post it here soon

@bacherfl bacherfl added enhancement New feature or request needs triage New item requiring triage labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Pinging code owners:

  • testbed: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage testbed
Projects
None yet
1 participant