Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Deduplication #34141

Open
nicolastakashi opened this issue Jul 17, 2024 · 4 comments
Open

Metrics Deduplication #34141

nicolastakashi opened this issue Jul 17, 2024 · 4 comments
Labels
enhancement New feature or request processor/metricstransform Metrics Transform processor waiting-for-code-owners

Comments

@nicolastakashi
Copy link
Contributor

nicolastakashi commented Jul 17, 2024

Component(s)

processor/metricstransform

Is your feature request related to a problem? Please describe.

Previously, I created an issue (#20921) proposing a new component to deduplicate metrics before they are remotely written to a data store.

During today’s Collector SIG Meeting on 17/07/2024, I presented a proof of concept (POC) I built over the last few days, which is available at this link: https://github.com/nicolastakashi/metricsdedupprocessor. We discussed whether this functionality should be implemented as a new component or as an additional feature in the metrics transform processor.

This issue is to discuss whether this should be implemented as a new component, or to have it done as part of the existing metricstransform processor component, during the meeting most of the maintainers seems to prefer if possible add a new feature to an existing component rather than a new component, and I'd like to discuss more about this strategy.

Describe the solution you'd like

Have the ability to deduplicate metrics based on DataPoints Attributes

Describe alternatives you've considered

N/A

Additional context

N/A

@nicolastakashi nicolastakashi added enhancement New feature or request needs triage New item requiring triage labels Jul 17, 2024
@github-actions github-actions bot added the processor/metricstransform Metrics Transform processor label Jul 17, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@nicolastakashi
Copy link
Contributor Author

Hey @dmitryax did you had the opportunity to check this issue?

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 11, 2024
@nicolastakashi
Copy link
Contributor Author

I still think it might be useful and waiting feedback, a friendly ping to @dmitryax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request processor/metricstransform Metrics Transform processor waiting-for-code-owners
Projects
None yet
Development

No branches or pull requests

2 participants