Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glider Parser invalid change #154

Open
s-pearce opened this issue Mar 24, 2014 · 0 comments
Open

Glider Parser invalid change #154

s-pearce opened this issue Mar 24, 2014 · 0 comments

Comments

@s-pearce
Copy link

In the glider parser at these lines:
https://github.com/ooici/marine-integrations/blame/master/mi/dataset/parser/glider.py#L468-L470
The num_hdr_lines variable is not updated as described by the comment. The comment was left from the original implementation of the glider parser code where num_hdr_lines is set as 14 NOMINALLY and then double checked and updated from the num_ascii_tags header value, which tells how many actual lines are in the header.

See original implementation here:
https://github.com/s-pearce/marine-integrations/blob/cgldr/mi/dataset/parser/glider.py#L626-L635

Unless Teledyne Webb Research (the glider vendor) says that glider data files will always and forever have 14 lines in the header (and even then I wouldn't trust it to be true), you may want to include a check of the num_ascii_tags header line to make sure there is 14 lines and update it if not.
-Stuart Pearce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant