-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deterministic IDs on SimpleFeatures #791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
https://github.com/onthegomap/planetiler/actions/runs/7527978119 ℹ️ Base Logs 14b217d
ℹ️ This Branch Logs a96145e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran openmaptiles profile over the planet after #785 #788 and #789 and the only remaining diffs were in boundary and POI layers due to the fact that they create
SimpleFeature
instances in a finish handler method, which use an ID generator that results in different IDs each time it runs. This PR adds the ability for profiles to set the ID explicitly on these simple feature, and defaults to no ID. With this change I was able to get the same md5 hash on pmtiles generated by 2 consecutive planet runs of the openmaptiles profile.