-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Join Wagtail Nest / merge with Wagtail Math #7
Comments
Posted a similar question on Wagtail math. wagtail-nest/wagtail-polymath#11 |
Hi, thank you for your invitation, that sounds good.
I've been thinking about this before, and I think something like |
That's great news @ongchi - would you rather both packages get moved to Wagtail Nest (this one and Wagtail Math) or are you OK to merge this repo's code into a new repo/project that will support both MathJax and Katex? My thinking is that will be easier for a community, including yourself and the author of Wagtail Math to have one text to diagram/math package instead of multiple. Either way, you would still be an author and have permissions to merge in the new repo but a few of us would have to help each other to get the code into a place that aligns with the Wagtail cookie cutter approach. |
Hi @lb- , I think it's reasonable to merge this package into Wagtail Math and make the package support both KaTeX and MathJax rendering engines. This could be done by providing separate components or a config variable to let users decide. |
Thank you for being up for a merge of functionality, we would 100% love to get your support in this and hopefully with a few others from the community involved it wont be as difficult to keep the project maintained as Wagtail continues to release changes. As the next step I will raise a new discussion on the Wagtail Nest repo, get feedback on the naming and then we can working through the migration/merging. |
https://github.com/orgs/wagtail-nest/discussions/3 discussion raised - would love any input on naming and process if you have a bit more time to chime in @ongchi |
@ongchi - quick update. Wagtail-math has now moved to https://github.com/wagtail-nest/wagtail-polymath/ I have invited to you to be a member of that repo if you are up for helping merge your code into that repo (we will work out the details of this a bit later). |
@ongchi just wondering if you are still keen on being involved with this migration/merging in some form. |
Oh! Sorry, I completely forgot about this project for a while. |
Great @ongchi I have added you as a maintainer on the repo. Not sure on how we can coordinate next steps, we do have a Wagtail package guidelines which we would probably want to start to work towards at some point. https://github.com/wagtail/wagtail/wiki/Python-Package-Maintenance-Guidelines |
Here is my short-term plan for this project:
|
Awesome |
@ongchi fwiw, I've opened wagtail-nest/wagtail-polymath#12 to add support for Wagtail 5.2+. It also aligns it to the wagtail-nest guidelines. I did not rename it to |
Hi @zerolab, many thanks for your effort. The I believe we could start to merge this project into wagtail-polymath with a few modifications after wagtail-nest/wagtail-polymath#12 is merged. |
Thank you @ongchi wagtail-nest/wagtail-polymath#12 is now merged |
Awesome! |
Hi. I'm not sure if this is something that would be worth discussing but would there be interest for this package to move to Wagtail Nest. I'm on the Wagtail core team and see that this kind of package looks useful to the community and may need a bit more community support to keep updated.
Additionally, there is a similar package Wagtailmath (uses the MathJax engine) that maybe could be merged together when bringing into the Nest group.
There may even be a desire to support multiple 'text to diagram' engines like Mermaid / Pintora under one package banner.
Let me know if you would be interested. The Wagtail Nest documentation explains what this would mean.
https://github.com/wagtail-nest
The text was updated successfully, but these errors were encountered: