Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kingfisher 5.3] Prefetcher heap corruption #1147

Closed
seanliu1 opened this issue Mar 27, 2019 · 3 comments
Closed

[Kingfisher 5.3] Prefetcher heap corruption #1147

seanliu1 opened this issue Mar 27, 2019 · 3 comments

Comments

@seanliu1
Copy link

seanliu1 commented Mar 27, 2019 •
edited
Loading

Issue Description

I use prefetcher to prefetch images. I encountered crashes due to heap corruption. The issue is not existed in Kingfisher 5.2
I can frequently reproduce this issue using UITests

I attached the screenshot, but it should not be valuable since it is related to heap corruption

What

malloc: Heap corruption detected, free list is damaged at 0x28191e710
*** Incorrect guard value: 4332270768

Screen Shot 2019-03-27 at 12 53 02 PM

Screen Shot 2019-03-27 at 12 56 12 PM
@seanliu1 seanliu1 changed the title [Kinfisher 5] Prefetcher heap corruption [Kingfisher 5] Prefetcher heap corruption Mar 27, 2019
@seanliu1
Copy link
Author

I have also seen -[NSTaggedPointerString count]: unrecognized selector sent to instance 0x8000000000000000
Not sure if it is related to heap corruption
Screen Shot 2019-03-27 at 1 16 41 PM

@seanliu1 seanliu1 changed the title [Kingfisher 5] Prefetcher heap corruption [Kingfisher 5.3] Prefetcher heap corruption Mar 27, 2019
@onevcat
Copy link
Owner

onevcat commented Mar 28, 2019

It seems to be a regression of a thread issue in image prefetcher. I will try to give it a fix today.

@onevcat onevcat mentioned this issue Mar 28, 2019
Merged
@onevcat
Copy link
Owner

onevcat commented Mar 28, 2019

Should be fixed in version 5.3.1.

@onevcat onevcat closed this as completed Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onevcat @seanliu1