Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make disjoint pool a C structure #898

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bratpiorka
Copy link
Contributor

@bratpiorka bratpiorka commented Nov 14, 2024

make Disjoint Pool a C structure. With this PR:

  • Disjoint Pool code is written in C - NOTE: there are no changes in any algorithm - any optimizations should be done in separate PRs
  • it is no longer a lib - it is always added to UMF lib sources
  • UMF_BUILD_LIBUMF_POOL_DISJOINT option is removed
  • few white-box test cases where we look at internal structures are added - more could be added in separate PRs

@bratpiorka bratpiorka requested a review from a team as a code owner November 14, 2024 13:30
@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft November 14, 2024 13:39
@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 3 times, most recently from 97807f1 to 3521be5 Compare November 18, 2024 10:14
@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 8 times, most recently from 17d00a2 to 9b22721 Compare November 27, 2024 09:57
src/pool/pool_disjoint.c Fixed Show fixed Hide fixed
src/pool/pool_disjoint.c Fixed Show fixed Hide fixed
@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 14 times, most recently from cdad0f1 to 4a8935a Compare December 6, 2024 15:03
@bratpiorka
Copy link
Contributor Author

@lukaszstolarczuk with this PR we need to change the required "check" to some other Fast Build

@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 3 times, most recently from 2806755 to 33a83ca Compare December 7, 2024 17:47
@bratpiorka bratpiorka changed the title [WIP] make disjoint pool a C structure make disjoint pool a C structure Dec 9, 2024
@bratpiorka bratpiorka marked this pull request as ready for review December 9, 2024 14:03
@bratpiorka bratpiorka requested review from ldorau and lplewa December 9, 2024 14:03
src/pool/pool_disjoint.c Outdated Show resolved Hide resolved
src/pool/pool_disjoint.c Outdated Show resolved Hide resolved
src/pool/pool_disjoint.c Show resolved Hide resolved
src/pool/pool_disjoint.c Outdated Show resolved Hide resolved
src/pool/pool_disjoint.c Outdated Show resolved Hide resolved
src/pool/pool_disjoint.c Outdated Show resolved Hide resolved
src/pool/pool_disjoint.c Outdated Show resolved Hide resolved
@igchor
Copy link
Member

igchor commented Dec 9, 2024

@bratpiorka before merging this we will definitely need to run a few sycl-level benchmarks

@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 4 times, most recently from 1bf955a to 0fa2440 Compare December 10, 2024 14:07
@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 3 times, most recently from 706aa96 to b2d07ad Compare December 11, 2024 14:22
@bratpiorka
Copy link
Contributor Author

@lplewa please review :)

@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 3 times, most recently from 0d2e129 to c87e492 Compare December 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants