Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instable connection to RPC causes incorrect operations with tokens in BW plugin #445

Open
akolotov opened this issue Sep 28, 2020 · 0 comments
Open

Instable connection to RPC causes incorrect operations with tokens in BW plugin #445

akolotov opened this issue Sep 28, 2020 · 0 comments
Labels
bug Something isn't working bw2-plugin

Comments

@akolotov
Copy link
Collaborator

It has been discovered that the following code returns false if a RPC endpoint used by the burner wallet core return errors (e.g. quota limit for the infura endpoint):

https://github.com/poanetwork/tokenbridge/blob/48dd53622c5b13cef5d9ae923cc148eb77b61d0a/burner-wallet-plugin/tokenbridge-bw-exchange/src/burner-wallet/assets/BridgeableERC20Asset.ts#L33-L43

It causes that the token is sent to the bridge/mediator contract by the transfer method instead of the pair of methods approve + relayTokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working bw2-plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akolotov