Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xing backend broken #871

Closed
Chronial opened this issue Mar 18, 2016 · 4 comments
Closed

Xing backend broken #871

Chronial opened this issue Mar 18, 2016 · 4 comments

Comments

@Chronial
Copy link
Contributor

It breaks here:

profile = self.get_json(

Xing doesn't like that we transmit the oauth parameters oauth_callback and oauth_verifier in the request (set here:

callback_uri=self.get_redirect_uri(state),
). These are actually not needed anymore in this request (auth is done) and Xing fails this request with a 400.

@Chronial
Copy link
Contributor Author

Note: I fixed this locally for my project – all that is required is to generate the OAuth1 for this one call without the two problematic parameters.

@Andygmb
Copy link
Contributor

Andygmb commented Mar 29, 2016

@Chronial - if you fixed it locally you should submit a pull request with that fix.

@Chronial
Copy link
Contributor Author

@Andygmb In general I agree, but I think this change is more about architecture. My local fix feels to dirty for the actual library, as it only fixes Xing.

I think this should be fixed for every Oauth provider. oauth_callback and aouth_verifier should only be send on the first call, not all subsequent api calls. Xing is just the only provider that complains, but it's just as wrong for every other one.

@omab
Copy link
Owner

omab commented Dec 26, 2016

Fixed by python-social-auth/social-core@b78159c.

@omab omab closed this as completed Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants