Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster refresh failed when using pasword file with isCluster mode #836

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

chetratep
Copy link
Contributor

This PR is to fix the bug when using password file with isCluster mode.

This issue #835

@coveralls
Copy link

coveralls commented Sep 21, 2023

Pull Request Test Coverage Report for Build 210

  • 3 of 7 (42.86%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 92.009%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exporter/redis.go 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
exporter/exporter.go 13 94.36%
Totals Coverage Status
Change from base Build 196: 0.02%
Covered Lines: 1946
Relevant Lines: 2115

💛 - Coveralls

@oliver006
Copy link
Owner

Thanks for the PR, I'll try to review it in the next few days!

@oliver006
Copy link
Owner

I think this makes sense.

Can you please add a test to confirm the expected behavior is working ?

@chetratep
Copy link
Contributor Author

Sure, I'll find sometime later to do it.

@oliver006
Copy link
Owner

Quick bump @chetratep

@oliver006
Copy link
Owner

Thanks for adding the tests @chetratep !

@oliver006 oliver006 merged commit 82aa26f into oliver006:master Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants