Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream bash-completion patches #717

Open
andychu opened this issue Apr 17, 2020 · 0 comments
Open

upstream bash-completion patches #717

andychu opened this issue Apr 17, 2020 · 0 comments

Comments

@andychu
Copy link
Contributor

andychu commented Apr 17, 2020

I was reminded me of this since neofetch accepted some patches ( #679 ), and as of Oil 0.8.pre4, we have $OIL_VERSION.


I have a year-old fork here:

https://github.com/oilshell/bash-completion/

But I believe it shouldn't be that out of date, because the changes are mostly in one file (and also because bash-completion is a decades-old and stable project). As far as I remember, I implemented the compadjust builtin in Oil to do what a few hundred lines of bash did there.

TODO: look at the code again :)


I still want completion with descriptions like zsh and fish, which bash doesn't allow for. #315

But I think people will use bash-completion for a long time, so this is worth doing.


carrot for upstream: coverage #687 . They have automated tests, so seeing coverage info would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant