Implement shopt -s dotglob in OSH, glob() enhancements in YSH

[andychu]

Related to #609 and #552

This should just be a libc flag change. Maybe wait until after translation is done?

[andychu]

There's a failing spec test for this in spec/glob.test.sh

$ test/spec.sh glob  -r 35 
glob.test.sh
case    line    dash    bash    mksh    ash     osh
 35     293     N-I     pass    N-I     N-I     FAIL    dotglob (bash option that dashglob is roughly consistent with)

                dash    bash    mksh    ash     osh
        pass    0       1       0       0       0
        N-I     1       0       1       1       0
        FAIL    0       0       0       0       1
        total   1       1       1       1       1

[andychu]

Demo

$ mkdir tmp
$ cd tmp
$ touch a b .bashrc
$ echo *
a b
$ shopt -s dotglob
$ echo *
a b .bashrc

[andychu]

man glob

       GLOB_PERIOD
              Allow a leading period to be matched by metacharacters.  By default, metacharacters can't match a leading period.

[jtb20]

There's a good amount of horror to be seen here: https://superuser.com/questions/352289/bash-scripting-test-for-empty-directory! It's like a one-page summary of why ysh is needed all by itself.

I tried writing an "empty directory" test in ysh (0.21.0), but hit this issue:

func dir_empty (where) {
  cd $where {
    # shopt "dotglob" appears to be unimplemented. This'll do.
    var files=glob("*")++glob(".*")
    return (len(files) === 2)
  }
}

Not critical or anything, just a FYI.

[andychu]

OK interesting

osh-0.21.0$ = glob('*')
(List 0x7fb9cd964af0)   []
osh-0.21.0$ = glob('.*')
(List 0x7fb9cd964c30)   [".",".."]

I didn't know this was the behavior of glob

I think there are two different things here

• bash-compatible shopt -s dotglob
• optional args to glob() function in YSH

[jtb20]

Test case:

dotglob.ysh.txt

HTH!