Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displayName not proxied #9

Open
mingfang opened this issue May 9, 2015 · 3 comments
Open

displayName not proxied #9

mingfang opened this issue May 9, 2015 · 3 comments

Comments

@mingfang
Copy link

mingfang commented May 9, 2015

When using with react-breadcrumb I always see the breadcrumb as "ReactProxy", even though my route sets the displayName property.

@seanadkinson
Copy link
Contributor

Cool, I didn't know about react-breadcrumbs.

I'm not sure how dynamic we can make the proxy's displayName, but go ahead and give this branch a try: https://github.com/odysseyscience/react-router-proxy-loader/tree/react-breadcrumbs-issue-9

You can pull the branch by putting this in your package.json:

...
"react-router-proxy-loader": "odysseyscience/react-router-proxy-loader#react-breadcrumbs-issue-9",
...

Let me know if that helps at all, and I can push a real update.

@mingfang
Copy link
Author

I can see using the debugger that the displayName is set correctly.
Unfortunately react-breadcrumb appears to not pick it up correctly.
I created an issue here https://github.com/svenanders/react-breadcrumbs/issues/10

@seanadkinson
Copy link
Contributor

Well it's probably not their fault. It's probably because I'm changing it after they've already read it, and no one expects the displayName to be dynamic.

Sent from my iPhone

On May 9, 2015, at 5:53 PM, Ming Fang [email protected] wrote:

I can see using the debugger that the displayName is set correctly.
Unfortunately react-breadcrumb appears to not pick it up correctly.
I created an issue here svenanders/react-breadcrumbs#10


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants