Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove // @ts-ignore statements #43

Open
gr2m opened this issue Jan 16, 2020 · 2 comments · May be fixed by #110
Open

Remove // @ts-ignore statements #43

gr2m opened this issue Jan 16, 2020 · 2 comments · May be fixed by #110
Assignees
@copperwall
Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@gr2m
Copy link
Contributor

gr2m commented Jan 16, 2020

I had to rush the transition to TypeScript a little bit. Instead of setting the correct types everywhere, I've added a few // @ts-ignore statements:
https://github.com/octokit/plugin-retry.js/search?q=%22%2F%2F+%40ts-ignore%22&unscoped_q=%22%2F%2F+%40ts-ignore%22

I'd love a pull request that remove them and sets the correct types instead. Ask away if you have any questions
@gr2m gr2m added the feature label May 5, 2020
@copperwall
Copy link
Member

Hey @gr2m! I'd love to work on this if this is still a valid issue

@gr2m
Copy link
Contributor Author

gr2m commented Jun 29, 2020

All yours :) There are @ts-ignore statements left in wrap-request.ts and error-request.ts

@gr2m gr2m removed the help wanted label Jun 29, 2020
@copperwall copperwall linked a pull request Jul 4, 2020 that will close this issue
Open
@gr2m gr2m assigned gr2m and unassigned gr2m Sep 15, 2020
@wolfy1339 wolfy1339 added Status: Blocked Some technical or requirement is blocking the issue Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@copperwall copperwall

Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ts-ignores annotations copperwall/plugin-retry.js
4 participants
@gr2m @copperwall @wolfy1339 @kfcampbell