Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Unnecessary allocations during json string parsing #2976

Open
1 task done
ToddGrun opened this issue Oct 26, 2024 · 1 comment · May be fixed by #2977
Open
1 task done

[BUG]: Unnecessary allocations during json string parsing #2976

ToddGrun opened this issue Oct 26, 2024 · 1 comment · May be fixed by #2977
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@ToddGrun
Copy link

What happened?

Looked at a profile of Visual Studio solution open, noticed more allocations than expected in octokit.

Versions

Octokit.Net: 10.0.0.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ToddGrun ToddGrun added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Oct 26, 2024
@ToddGrun
Copy link
Author

ToddGrun commented Oct 26, 2024 •
edited
Loading

PR here: #2977

*** allocations in VS solution load before these changes ***
image

@ToddGrun ToddGrun linked a pull request Oct 26, 2024 that will close this issue
Open
4 tasks
@nickfloyd nickfloyd moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Status: 🔥 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce string allocations during SimpleJson.ParseString ToddGrun/octokit.net
1 participant
@ToddGrun