-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub IDs have exceeded Int32.MaxValue; Octokit uses int #2351
Comments
An example PR where we've had to fix this in the past: #1703 Happy to push out a release asap about it if you have a fix. |
@patriksvensson got a sample script that helps us to know where it's overflowing? |
For those following along, I am using the following regex search in VS to attempt to find int Ids and knocking them out:
|
@shiftkey I'm not quite sure how the songs are chosen for releases, but this one seems like "For the Long-est Time" would be appropriate. |
Release titles are chosen mostly at random. I endorse this name for the one that fixes this. |
@shiftkey I don't have a sample script, but encountered this when retrieving notifications. |
@patriksvensson question as I go through this: You mention that you were having issues when retrieving notifications. It looks like, in a strange turn of events, the API is actually returning the notification ID as a string (and Octokit .NET is complying with that). Thread IDs are integers, but Octokit is currently compliant with that as well. Are you by any chance casting it to an integer on your end? The rest of this is still worth addressing, but I wanted to point out that it may not resolve your particular issue. |
Is there any progress on resolving this? #2352 appears stalled, but, sadly, this is stymieing any use of octokit.net for handling |
Migrates all integer types from `int` (32-bit) to `long` (64-bit). Could I be a bit more directed with these changes? Probably. But the it's simpler and easier to migrate all `int`s to `long`s rather than debate how large a specific ID is going to be. Closes #30 References: - #30 - octokit/octokit.net#2351 - octokit/octokit.net#2352 - https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/integral-numeric-types
👋 Hey Friends, this issue has been automatically marked as |
According to the documentation at https://docs.github.com/en/rest/issues/issues. Fixes octokit#2351 for issue ids.
According to the documentation at https://docs.github.com/en/rest/issues/issues. Fixes octokit#2351 for issue ids.
Spotted in this tweet from @patriksvensson: https://twitter.com/firstdrafthell/status/1429738272574558210?s=19
I'll look into this ASAP but don't mind anyone else doing the same.
The text was updated successfully, but these errors were encountered: