Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long strings overflowing their container in extension layout #1864

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Mar 30, 2024

Fixes #1862

Before After
wallet oasis io_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90_paratimes wallet oasis io_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90_paratimes
wallet oasis io_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90_paratimes(extension360x600) (1) wallet oasis io_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90_paratimes(extension360x600)

@lukaw3d lukaw3d requested a review from buberdds March 30, 2024 03:12
Copy link

github-actions bot commented Mar 30, 2024

Deployed to Cloudflare Pages

Latest commit: d54191df1f2d601b0ce4f3cb3a1563f598f3cf97
Status:✅ Deploy successful!
Preview URL: https://75e26433.oasis-wallet.pages.dev

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (338485e) to head (d54191d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1864      +/-   ##
==========================================
- Coverage   81.29%   81.21%   -0.08%     
==========================================
  Files         192      192              
  Lines        5084     5084              
  Branches      936      936              
==========================================
- Hits         4133     4129       -4     
- Misses        951      955       +4     
Flag Coverage Δ
cypress 46.03% <0.00%> (ø)
jest 77.06% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../app/pages/ParaTimesPage/ParaTimeContent/index.tsx 100.00% <ø> (ø)
...pp/pages/ParaTimesPage/ParaTimeSelection/index.tsx 92.59% <ø> (ø)
...es/ParaTimesPage/TransactionConfirmation/index.tsx 95.65% <ø> (ø)
...app/pages/ParaTimesPage/TransactionError/index.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@lukaw3d lukaw3d merged commit 9fd6c69 into master Apr 1, 2024
14 of 15 checks passed
@lukaw3d lukaw3d deleted the lw/extension-long-strings branch April 1, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension: wrap addresses / long strings
2 participants