-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Book #1635
Merged
Address Book #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## master #1635 +/- ##
==========================================
- Coverage 82.67% 81.21% -1.46%
==========================================
Files 163 171 +8
Lines 4180 4345 +165
Branches 745 777 +32
==========================================
+ Hits 3456 3529 +73
- Misses 724 816 +92
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
force-pushed
the
mz/addr
branch
11 times, most recently
from
September 8, 2023 10:21
db21303
to
92b3ad8
Compare
buberdds
force-pushed
the
mz/addr
branch
2 times, most recently
from
September 8, 2023 10:58
e9c8a1a
to
e5031e3
Compare
lukaw3d
reviewed
Sep 8, 2023
src/app/components/Toolbar/Features/Contacts/ContactAccountForm.tsx
Outdated
Show resolved
Hide resolved
src/app/components/Toolbar/Features/Contacts/ContactAccountForm.tsx
Outdated
Show resolved
Hide resolved
src/app/components/Toolbar/Features/Contacts/ContactAccountForm.tsx
Outdated
Show resolved
Hide resolved
buberdds
force-pushed
the
mz/addr
branch
5 times, most recently
from
September 11, 2023 10:15
7814ac8
to
45be84f
Compare
lukaw3d
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of Address Book feature. I will add tests in a next PR (or after the first round of review) . In many places I am not following mockups strictly and I am using existing Grommet components etc.