Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sarif 2.1.0 schema url in Schemata stopped working #646

Open
jsoref opened this issue Jul 11, 2024 · 2 comments
Open

sarif 2.1.0 schema url in Schemata stopped working #646

jsoref opened this issue Jul 11, 2024 · 2 comments

Comments

@jsoref
Copy link

jsoref commented Jul 11, 2024

#633 renamed the sarif 2.1.0 schema.

something renamed the default branch from master to main.

I was linking to the file in order to generate my json which enables json validators to be happy...
https://github.com/check-spelling/check-spelling/blob/26b46adbdebd5dd0b34c7155113d50c40f43fb22/sarif.json#L2

  "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",

The above collective changes have broken that.

There doesn't appear to be any tag that I could use instead. What is the recommended practice for content generators?

Are we supposed to link to a specific sha?

@KalleOlaviNiemitalo
Copy link

@jsoref
Copy link
Author

jsoref commented Jul 11, 2024

Fwiw, there are ~3k hits for this url: https://github.com/search?q=%22https%3A%2F%2Fraw.githubusercontent.com%2Foasis-tcs%2Fsarif-spec%2Fmaster%2FSchemata%2Fsarif-schema-2.1.0.json%22&type=code

I'm happy to change my code, but I can't change everyone else's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants