fix: Support retrieving the head SHA from workflow_run
#549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For secure workflow as Github officially advises, a
pull_request
event should perform a build for untrusted code and then make that available to aworkflow_run
triggered workflow when secrets are needed. Such as deployment. As the 2nd workflow (workflow_run
) is run from the main/production branch (eg master), it will have the wrongcontext.sha
value.The head commit SHA is available matching that of the pull_request event, using this will allow the action to apply it's features correctly to the intended commit on pull request, not on production branch latest commit.
Note: this is untested. I have not yet developed a Github Action, please test and review first.
AFAIK, assuming I got the
context
value correct (I am having trouble finding documentation on this), it should work correctly and only apply toworkflow_run
triggered workflows. I am not sure if it is always desirable to use the head SHA, but for typicalpull_request
event that would trigger theworkflow_run
, I believe it makes the most sense.Alternatively, a user input could take priority which is more flexible?