-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref!: major refactor #150
ref!: major refactor #150
Conversation
the main idea of there i think we can now remove the custom spawn logic and move to vim.system with coroutine wrapper. |
Co-authored-by: glepnir <[email protected]>
I can try... |
|
|
<3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work. some edge cases can fix in later.
hi hello you accidentally started writing double newlines to the linter (guard.nvim adds a newline to the end of each line in https://github.com/nvimdev/guard.nvim/blob/main/lua/guard/util.lua#L9-L16, and then nvim's SystemObj:write() adds a newline to the end of every line it writes, see https://github.com/neovim/neovim/blob/5331f87f6145f705c73c5c23f365cecb9fbc5067/runtime/lua/vim/_system.lua#L122-L125) which means the linter gets line numbers wrong and keeps complaining about there being too many newlines. |
Oh wow nice catch! That explains why clippy always reports the double amount of line number. I will push a fix tonight after some more testing. |
closes #68 #86 #123 #109 #76 #141 #111
changes
do_lint
now respects all config fieldsinternal changes