fix(link): Remove hash before checking if ending by '.md' #2033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Type of change
Does not know if it's a bug fix or an enhancement.
π Description
The PR consists of allowing hash in a relative title.
Example of an URL used in our md files :
../docs/04.developer-guide/04.inputs.md#set-inputs-with-curl
Without the hash part, this works fine and the URL is well interpreted, but we notice that having a hash will break the functionality.
In fact, the method
normalizeLink()
works only with relative files that end with.md
, so we added hash handling in this function, which is just a regex that removes hash, and set it back before returning.π Checklist