feat(shiki): highlight excerpt #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt-content ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
farnabaz
reviewed
Jan 9, 2023
| @@ -1,4 +1,5 @@ | |||
| import { visit } from 'unist-util-visit' | |||
| import { MarkdownRoot } from '../../types' | |||
There was a problem hiding this comment.
Suggested change
| import { MarkdownRoot } from '../../types' | |
| import type { MarkdownRoot } from '../../types' |
farnabaz
reviewed
Jan 9, 2023
|
|
||
| await Promise.all(codeBlocks.map(highlightBlock)) | ||
| await Promise.all(inlineCodes.map(highlightInline)) | ||
| // TODO copy highlighted body to excerpt if it is the same |
There was a problem hiding this comment.
Suggested change
| // TODO copy highlighted body to excerpt if it is the same |
Based on your other PR, #1801 (comment). I think we can simply remove this line
Qwertovsky
force-pushed
the
highlight_excerpt
branch
from
5f5aeca to
7329679
Compare
Qwertovsky
force-pushed
the
highlight_excerpt
branch
from
7329679 to
4cf6d81
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Highlight the excerpt.
Because the excerpt contains a code too.
📝 Checklist