-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add og:title,url,description
meta tags and prefix og:image
with host
#1769
Conversation
β Deploy Preview for nuxt-content ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
og:title
and og:url
meta tags and prefix og:image
with hostog:title,url,description
meta tags and prefix og:image
with host
Thanks @danielroe , what would you suggest for canonical? |
I would recommend, for now, we add a |
No need for redirect if we set the canonical meta tag indeed. Those Happy to update the PR and uncomment your code? |
What should we do with canonical? Uncomment or keep it commented? Also, What do you think about using /cc @atinux @danielroe |
I like the idea of trying to guess the host as much as possible |
Regarding the canonical, what do you suggest @danielroe ? |
Sorry for the delay on this! I've guarded open graph integration behind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
π Linked issue
β Type of change
π Description
The OpenGraph spec requires:
https://www.imdb.com/title/tt0117500/
".Two url related issues come up for future attention:
og:url
for whatever url was actually accessed, but this is not optimal - ideally there's a canonical form of the url.rel=canonical
URLs for document driven mode - this depends on the point aboveπ Checklist