Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor appliers to use option when there are multiple UDFs #1809

Closed
Tracked by #1688
vigith opened this issue Jul 10, 2024 · 0 comments · Fixed by #1816
Closed
Tracked by #1688

Refactor appliers to use option when there are multiple UDFs #1809

vigith opened this issue Jul 10, 2024 · 0 comments · Fixed by #1816
Assignees
@kohlisid
Labels
area/forward Forward/Map

Comments

@vigith
Copy link
Member

vigith commented Jul 10, 2024 

          I am not fully in favor of this way of sending appliers to forward. This is because even if we need just `MapUDF`, we still have to set the other `UDFs`. So, I'm thinking, should we use an options approach for all appliers? This way, we just pass the option that we need.

Originally posted by @yhl25 in #1778 (comment)
@kohlisid kohlisid changed the title I am not fully in favor of this way of sending appliers to forward. This is because even if we need just MapUDF, we still have to set the other UDFs. So, I'm thinking, should we use an options approach for all appliers? This way, we just pass the option that we need. Refactor appliers to use option when there are multiple UDFs Jul 10, 2024
This was referenced Jul 11, 2024
Merged
Closed
@vigith vigith added the area/forward Forward/Map label Jul 11, 2024
@kohlisid kohlisid mentioned this issue Jul 11, 2024
Merged
@kohlisid kohlisid self-assigned this Jul 12, 2024
@kohlisid kohlisid mentioned this issue Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kohlisid kohlisid

Labels
area/forward Forward/Map
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update map appliers to use options kohlisid/numaflow
2 participants
@vigith @kohlisid