Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to produce a SecretKeyFactory from another factory deterministically. #59

Closed
fjarri opened this issue Jul 3, 2021 · 2 comments · Fixed by #64
Closed

Add a method to produce a SecretKeyFactory from another factory deterministically. #59

fjarri opened this issue Jul 3, 2021 · 2 comments · Fixed by #64
Labels
API Related to public API enhancement New feature or request
Milestone

Comments

@fjarri
Copy link
Contributor

fjarri commented Jul 3, 2021

Should we do it just by label? Or label + salt, to add randomness?

@fjarri fjarri added enhancement New feature or request API Related to public API labels Jul 3, 2021
@fjarri fjarri added this to the v1.0.0 milestone Jul 3, 2021
@cygnusv
Copy link
Member

cygnusv commented Jul 6, 2021

My understanding of the SKF abstraction is that the seed input is assumed of high entropy. Therefore, salt shouldn't be necessary (or at most, optional).

@fjarri
Copy link
Contributor Author

fjarri commented Jul 6, 2021

If it's not necessary, I'd rather not add an option if I can help it.

As for the implementation, I suppose I'll go the same way as secret_key_by_label() currently works, except deriving however many bytes SKF needs - is that secure enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to public API enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants