-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we need to carry around UmbralParameters
?
#3
Comments
Rather than calculate on the spot, it might be better to simply let this be a Another option is to serialize the point and store the bytes as a |
From the discussion: calculate it in a macro when the crate is built. |
Something I just realized - in Bundling gives us easy compatibility if we decide to change The main downside is that there is more data to come with the capsule (2 points = 66 bytes), with the rest of the capsule taking 98 bytes. How important that is is uncertain. KeyFrags (especially with the proofs) will take significantly more space. Another consideration could be the time of generating the parameters (mainly, the value of If we decide to have a default |
Another consideration: deriving Although if we decide to include both |
(starting to hate this issue)
|
Let's do it as you suggest (i.e. In that case, can we drop the parameters from capsules and other objects? The parameters will be static, if it's a problem for Rust to compute |
Ok, hiding Parameters for good - in #41 |
At the moment it only contains one field,
u
, which only depends on the curve selection. Calculating it takes ~10% of a single point-scalar multiplication (fork256
, 8us vs 100us), so in all places where it is used in can be safely created on the spot without a significant performance loss.The text was updated successfully, but these errors were encountered: