Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating value should be limited to 2 decimal points #174

Closed
ronakmshah opened this issue Nov 4, 2016 · 3 comments
Closed

floating value should be limited to 2 decimal points #174

ronakmshah opened this issue Nov 4, 2016 · 3 comments
Assignees

Comments

@ronakmshah
Copy link
Contributor

screen shot 2016-11-04 at 10 10 31 am

This disrupts the view. If showing floating values anywhere, it should always be shown with 2 decimal points max.

@curran
Copy link
Contributor

curran commented Nov 5, 2016

Related to

@curran
Copy link
Contributor

curran commented Nov 8, 2016

Related to set timestamp to yy:mm:dd:mm:ss in chord table #172

We can handle this by adding a configuration option for custom formatters for each column of the table. The formatter may be either a number format (hooking into d3-format) or a date format (hooking into d3-time-format).

Here's a sketch of what the configuration might look like:

"data": {
    "columns": [
        { "column": "SrcUplink", "label": "Source Uplink" },
        { "column": "DstUplink", "label": "Destination Uplink" },
        { "column": "PerfMonitor", "label": "Perf Monitor" },
        { "column": "AvgJitter", "label": "Avg Jitter", "format": ",.2f" },
        { "column": "AvgLatency", "label": "Avg Latency" , "format": ",.2f" },
        { "column": "AvgPacketLoss", "label": "Avg Pkt Loss" , "format": ",.2f" },
        { "column": "timestamp", "label": "Timestamp", "timeFormat": "%b %d, %y %X"}
    ]
},

@curran curran mentioned this issue Nov 8, 2016
@curran
Copy link
Contributor

curran commented Nov 8, 2016

@ronakmshah This is implemented in PR #188. I did not see the same thing as your screenshot under dashboards/aarDomain, so I added formatting for another table instead - public/configurations/visualizations/top20-talkers-domain.json. You should be able to take for formatter configurations introduced in #188 and apply them where you need formatting in all tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants