Add "Player color theme" setting #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt4f04uNd
commented
Oct 2, 2022
Abestanis
reviewed
Oct 2, 2022
There was a problem hiding this comment.
This is an awesome feature, really cool. Thanks for the video showcasing it!
I don't have much time right now, but I quickly looked over the code and only found a small copy and paste mistake, the rest looks good👍.
I think having a System choice which could use the color from the Material You on Android and the accent color on Windows would be a cool addition on top of this, once this is merged. I'll try this, once I have more time.
nt4f04uNd
force-pushed
the
feature/color-thief
branch
from
178af83 to
3088c15
Compare
Abestanis
reviewed
Dec 1, 2022
Co-authored-by: Abestanis <[email protected]>
…o feature/color-thief
Open
|
Phew, finally, merged this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting to choose how to color player interface.
Now interface is by default colored based on the current song art.
Video
Record_2022-10-02-20-42-36.mp4