Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following the releasing instructions results in an error when pushing #833

Open
mfisher87 opened this issue Oct 1, 2024 · 1 comment
Open
Labels
impact: documentation Improvements or additions to documentation type: bug Something isn't working

Comments

@mfisher87
Copy link
Collaborator

mfisher87 commented Oct 1, 2024

protected branch hook declined

...

Changes must be made through a Pull Request

Following the instructions as written only works if the releaser bypasses branch protections. They must be an admin or an admin must add them to the list of people allowed to bypass. I added @nikki-t to the bypass list, then cleaned up the list after she successfully pushed. IMO, We should instead document a release process that uses a branch and a PR to make the required changes.

Additionally, the uv-lock pre-commit job will fail on every release because it will try and resolve the new version into the environment lock file before it's been pushed to PyPI.

@jhkennedy
Copy link
Collaborator

Note: There's a relevant discussion of automating the release process in #857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: documentation Improvements or additions to documentation type: bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants