fixing parameter typo for rest.ipam.reservations.list method #76
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modiharsh04
previously approved these changes
Aug 6, 2021
modiharsh04
reviewed
Aug 6, 2021
|
@jeremypng once Harsh's comment above and failing tests are addressed, I think we're good to go on this one. |
|
Perhaps the contributors can fix this? Its been a while since this was raised after all.. |
I just pushed a commit to trigger the workflow because the logs expired. If I can tell why it is breaking I'll see if I can get it to pass. |
modiharsh04
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed parameter from scopeGroupId to scope_group_id to conform with API