feat(install-browsers): automatically detect out of sync playwright deps and attempt to install #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eps and attempt to install Sometimes when playwright releases a new version the system deps required also change. This change attempts to catch the out of sync deps from a playwright warning, and then install the deps playwright needs to prevent hard to debug issues with playwright not working.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bc09276. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
juristr
reviewed
Dec 3, 2024
| ); | ||
| console.error(installError); | ||
| console.log( | ||
| 'You can create a custom launch template and add a step to manually install the missing dependencies (desribed above from Playwright) in order to get around this error.', |
There was a problem hiding this comment.
Suggested change
| 'You can create a custom launch template and add a step to manually install the missing dependencies (desribed above from Playwright) in order to get around this error.', | |
| 'You can create a custom launch template and add a step to manually install the missing Playwright in order to get around this error.', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when playwright releases a new version the system deps
required also change. This change attempts to catch the out of sync deps
from a playwright warning, and then install the deps playwright needs to
prevent hard to debug issues with playwright not working.