Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Noir.js #2910

Closed
kevaundray opened this issue Sep 29, 2023 · 3 comments
Closed

Cleanup Noir.js #2910

kevaundray opened this issue Sep 29, 2023 · 3 comments
Assignees
@kobyhallx
Labels
enhancement New feature or request js Noir's JavaScript packages

Comments

@kevaundray
Copy link
Contributor

Problem

List of tracking items for cleaning up Noir.js and its related items:

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added the enhancement New feature or request label Sep 29, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 29, 2023
@kevaundray
Copy link
Contributor Author

kevaundray commented Oct 2, 2023 •
edited
Loading

Currently we call this.backend.instantiate when a user calls Noir.init and we also check to see if its called when we generate/verify a proof.

we should have a single strategy for this, ie always force users to call .init or always lazilly call it when a function needs it.

EDIT: The change above got reverted, see comment here I think we should do this in one step

This was referenced Oct 2, 2023
Merged
Merged
@kobyhallx kobyhallx self-assigned this Oct 9, 2023
@signorecello
Copy link
Contributor

I made some suggestions on it here as well: #3044

@signorecello signorecello mentioned this issue Oct 10, 2023
Closed
@Savio-Sou Savio-Sou added the js Noir's JavaScript packages label Oct 10, 2023
@kobyhallx kobyhallx moved this from 📋 Backlog to ✅ Done in Noir Oct 11, 2023
@Savio-Sou
Copy link
Collaborator

@kobyhallx safe to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kobyhallx kobyhallx

Labels
enhancement New feature or request js Noir's JavaScript packages
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@signorecello @kevaundray @Savio-Sou @kobyhallx