Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion in WinterCG Runtime Keys Proposal #166

Closed
Tracked by #2
Ethan-Arrowood opened this issue Oct 19, 2022 · 8 comments
Closed
Tracked by #2

Inclusion in WinterCG Runtime Keys Proposal #166

Ethan-Arrowood opened this issue Oct 19, 2022 · 8 comments

Comments

@Ethan-Arrowood
Copy link

Hello!

Wanted to share that I've published the draft for the runtime-keys proposal. It is heavily inspired by Node's existing usage of the node key as documented here: https://nodejs.org/dist/latest-v16.x/docs/api/packages.html#conditional-exports . I've included a section for Node.js in the proposal here: https://github.com/wintercg/runtime-keys/pull/2/files#diff-5e793325cd2bfc452e268a4aa2f02b4024dd9584bd1db3c2595f61f1ecf7b985R76-R84 and would like to get someone from either this working group or the TSC to essentially sign off on it. Let me know if you have any questions or feedback. Please also feel free to get involved in the proposal PR. Thank you!

@Ethan-Arrowood
Copy link
Author

@nodejs/tooling / @nodejs/tsc bump - want to get someone's sign off here before we proceed with the initial spec. Again, I don't see any conflict but want explicit acknowledgment before proceeding 😄

@jasnell
Copy link
Member

jasnell commented Nov 8, 2022

/cc @nodejs/tsc

@aduh95
Copy link

aduh95 commented Nov 8, 2022

I've added my 👍 on the linked issue as it looks good to me personally. I've added tsc-agenda label so we can discuss if there's a consensus for signing this off officially.

@mhdawson
Copy link
Member

mhdawson commented Nov 8, 2022

Looks fine to me

@joyeecheung
Copy link
Member

LGTM

@Trott
Copy link
Member

Trott commented Nov 9, 2022

At the TSC meeting today, nine TSC members had no concerns/objections. @mhdawson @Trott @GeoffreyBooth @cjihrig @aduh95 @BethGriggs @danielleadams @joyeecheung @tniessen

Is that enough for you to move forward?

@nodejs/TSC A few other pile-on 👍 reactions would be good to get this over the informal 50% threshold.

@Trott Trott removed the tsc-agenda label Nov 9, 2022
@Ethan-Arrowood
Copy link
Author

Thank you yes this is plenty sufficient for us to proceed. Thank you!

@Trott
Copy link
Member

Trott commented Nov 12, 2022

Thank you yes this is plenty sufficient for us to proceed. Thank you!

OK, I'm assuming this can be closed, but if I'm wrong and there's more to do here, by all means, re-open or leave a comment.

@Trott Trott closed this as completed Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants