-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proactively remove use of the _events object #184
Comments
sorry, extremely delayed response. do you have any suggestions? |
So, we are using I think the fix is more complicated: we need that functionality, and we will need to backport the change to the 1.x line (at least) to work on most-recent nodes. I propose that:
I see two options: the first is to add another method to EventEmitter The most important problem is the impact and amount of breakages it will have on the community. |
Relevant to the discussion: nodejs/node#6032 |
So, nodejs/node#6032 is about to land. The question is: should we backport the fix to v1.0 and v1.1, or we will implement it only in v2? We would probably need this fix when nodejs/node#5127 lands (likely for v7). I'm leaning towards deprecating v1 and v1.1 lines as proposed in #201 when 6 comes out, with a link pointing somewhere and explain why things will stop working on node v7 but are fine in node v6. @rvagg what do you think? |
nodejs/node#5127 is a planed breaking change that we will likely need to fix in readable-stream before they can land it in core
The text was updated successfully, but these errors were encountered: